bdnugget/magento2
1
0 Fork 0
mirror of https://github.com/bdnugget/magento2.git synced 2026-11-07 17:27:36 +00:00
Code Issues Packages Projects Releases Wiki Activity
143,425 Commits 1 Branch 0 Tags
2.4-develop
Commit Graph
48 Commits
Author SHA1 Message Date
Jacob Brown 7c8ef4ddee ACPT-1552 
* fixing more classes
* cleaning up more of the state-skip-list
 2023-12-12 16:44:43 -06:00
Jacob Brown d41452122a ACPT-1181: reset mutable state after request 2023-04-14 09:00:17 -05:00
Serhii Balko fbb3d510d2 MC-35755: [Magento Cloud] B2B - Negotiable Quotes REST response time is over 1 minute 2020-11-13 13:44:34 +02:00
Buba Suma 264f5b0c15 MC-38518: B2B - Qty update on cart - Page load time is high 
- Fix repetitive database queries in checkout process
 2020-10-28 14:44:07 -05:00
magento-team 6729b6e013 Updated deprecation doc annotations 2020-07-20 10:37:42 -07:00
Nikita Shcherbatykh 84daa3ff9f MC-21706: When products are added to a cart in the admin from a non-default website, the cart empties and nothing is added 2019-10-16 11:01:50 +03:00
nmalevanec fa5cf907e0 Fix static tests. 2019-04-16 17:24:30 +03:00
Bartłomiej Szubert 865d7df16d Fix #12802 - allow to override preference over \Magento\Quote\Api\Data\CartInterface and return correct object from QuoteRepository (+4 squashed commits) 
Squashed commits:
[55b9f3ec52b] Fix #12802 - fix phpmd, mark quoteFactory as deprecated
[56ca9a42468] Fix #12802 - change condition in quoteRepository
[734212812a4] Fix #12802 - revert change of constructor parameters names
[ba8ad543e0f] Fix #12802 - remove instanceof condition
 2019-04-05 11:47:22 +02:00
Viktor Tymchynskyi 0fdd197b32 MAGETWO-91330: [B2B] The product total price value on the second website is as on the default website 
- reverted fix from community PR #11165
- issue #7582 is fixed via plugin on store view switching
 2018-07-31 12:10:55 +03:00
Magento EngCom Team b9df95d3e2 ⏫ Forwardport of magento/magento2#11165 to 2.3-develop branch 
Applied pull request patch https://github.com/magento/magento2/pull/11165.patch (created by @bka) based on commit(s):
  1. 33dcc36b1f5214929f281c5618a31bbc6bded27b

Fixed GitHub Issues in 2.3-develop branch:
  - magento/magento2#7582: Payment methods in payments title in wrong language (reported by @Bartlomiejsz)
 2018-01-23 10:50:41 -06:00
Oleksii Korshenko 4b5626478a MAGETWO-71174: Update doc block information in php classes with @deprecated and @since tags 
- replaced release version with package version in @since and @depreacated tags
 - removed @since tag from private properties/methods  and non @api classes
 2017-08-04 19:15:55 -05:00
Oleksii Korshenko 56af1e73ce MAGETWO-71174: Update doc block information in php classes with @deprecated and @since tags 
- removed @since 2.0.0 as it is a base release
 - updated version in @since and @deprecated tag taking into account all patch releases
 2017-08-02 14:14:33 -05:00
Oleksii Korshenko bd74370771 MAGETWO-71174: Update doc block information in php classes with @deprecated and @since tags 
- added release number to all existing @deprecated tag in php classes, methods and properties (app/code/Magento, lib/internal/Magento, setup/src/Magento/Setup)
 - added tag @since to all existing php classes, methods and properties (app/code/Magento, lib/internal/Magento, setup/src/Magento/Setup)
 2017-07-28 15:43:18 -05:00
Igor Melnikov dc6e518715 MAGETWO-67871: Requesting autogenerated classes that are not in constructor cause fatal errors in production mode 
- refactor
 2017-05-23 10:52:38 -05:00
Igor Melnikov 24a49782ea MAGETWO-67871: Requesting autogenerated classes that are not in constructor cause fatal errors in production mode 
- refactor
 2017-05-22 17:13:57 -05:00
Igor Melnikov a90311d533 MAGETWO-67871: Requesting autogenerated classes that are not in constructor cause fatal errors in production mode 
- move dependencies on autogenerated classes to constructor
- add static test
 2017-05-19 11:48:59 -05:00
Ievgen Shakhsuvarov 3f1bc523b2 MAGETWO-67344: Solve issues with API #9124 
- Merge Pull Request magento/magento2#9124 from ho-nl-fork/magento2:api-fixes
 2017-04-11 01:57:23 -07:00
Mikalai_Shostka e93c44e66d MAGETWO-66697: GET request to view quote details doesn't work 2017-04-04 16:26:10 +03:00
Paul Hachmang a9888e6323 Replaced SearchCriteria with SearchCriteriaInterface 2017-04-02 10:53:01 +02:00
James Halsall a31f4a35c0 Remove the copyright year from file headers 2017-02-22 09:09:36 +00:00
Sergii Kovalenko eb30343a09 MAGETWO-62855: Copyright Year Update 2017 2017-01-05 13:01:45 +02:00
Sviatoslav Mankivskyi 39c9b62015 MAGETWO-56080: SearchCriteria Unified Processing for Quote and Tax modules 2016-08-11 11:50:44 +03:00
Sergii Kovalenko 555751a04f MAGETWO-56080: SearchCriteria Unified Processing for Quote and Tax modules 2016-08-03 13:22:56 +03:00
Stanislav Idolov f53753e4f1 MAGETWO-53464: Reorder not load products 2016-05-31 09:10:06 +03:00
Stanislav Idolov b2ee65e464 MAGETWO-53464: Reorder not load products 2016-05-30 17:45:44 +03:00
Viktor Tymchynskyi 8989b9312b MAGETWO-50972: Move to Shopping Cart action does not work inside creation offline order 
- Remove wrong caching quote behavior
 2016-04-28 10:37:55 +03:00
Partica, Cristian 17fac5afe6 MAGETWO-51299: Order from admin is created with error while using non-default website 
- adding missing additional parameter on the get quote for non default storeId
 2016-04-07 16:08:33 -05:00
Ievgen Shakhsuvarov 68457cfc63 MAGETWO-48531: Shipping Address and Method in Quote API 2016-03-25 16:03:33 +02:00
Joan He 2d368d0134 MAGETWO-48081: Copyright Year Update 2016-03-17 15:49:11 -05:00
Serhiy Shkolyarenko e56bc23b94 MAGETWO-49460: CartRepositoryInterface can't be used twice 
updated fix
 2016-02-22 13:33:35 +02:00
Serhiy Shkolyarenko f06258ab57 MAGETWO-49460: CartRepositoryInterface can't be used twice 
suppressed mess detector message
 2016-02-22 11:22:14 +02:00
Serhiy Shkolyarenko d974a0b12c MAGETWO-49460: CartRepositoryInterface can't be used twice 
added collection reset on getList() call
 2016-02-19 18:03:26 +02:00
Stanislav Idolov 368b69b342 MAGETWO-44589: [Github] Make API jsonapi compliant 2015-10-26 17:55:23 +02:00
Stanislav Idolov 4e1281fef1 MAGETWO-44589: [Github] Make API jsonapi compliant 2015-10-26 16:52:28 +02:00
Serhiy Shkolyarenko 2dd3ef9d24 MAGETWO-41527: PHP 7 namespace strict compatibility 
- Updated Magento_Quote module for PHP 7 compatibility
 2015-10-06 17:41:07 +03:00
Andrey Konosov 44188aa8d5 MAGETWO-39814: [GITHUB] Improve \Magento\Framework\Api\SortOrder #1422 
- Fixed code style and static tests
 2015-07-28 18:56:34 +03:00
Vinai Kopp 8e66e3a188 Improve \Magento\Framework\Api\SortOrder 
Purpose
==

Make the specification of sort directions on sort criteria easier for developers.

Background
==

This PR addresses several issues:

**PHPDoc type hint mismatch**
All parameter type hints expecting a sort direction specify `@param string $direction`,
but the constants `SearchCriteriaInterface::SORT_ASC` and `SearchCriteriaInterface::SORT_DESC`
are integers.
As a developer, when I see a method `setDirection()` that takes a string, I expect the
argument to be either `ASC` or `DESC`. Neither work, but there is no error helpful error
message.

**Unintuitive placement of constants**
Also the location of the constants is not intuitive. When working with the code in question,
a developer is focused on the classes SortOrder and SortOrderBuilder. So the expectation
would be to find the class constants on either of those classes.

**Missing validation**
The sort direction can be specified as a scalar argument, but there is no validation.
This PR adds validation and throws an explanatory exception on validation failure.

Reasons for this PR
==

The motivation is to make it easier and more intuitive for developers to specify a sort order.
 2015-07-21 23:40:47 +02:00
Arkadii Chyzhov b279e4be80 MAGETWO-38293: [Add join processors to search service] Quote Module 2015-06-12 19:29:24 +03:00
Yu Tang 55d63cc9ae Merge branch 'FearlessKiwis-MAGETWO-32896-Quote-Immutability' into develop 
Conflicts:
	app/code/Magento/Quote/Model/Cart/ShippingMethodConverter.php
 2015-02-26 15:18:39 -06:00
Robert He 118a6b577a MAGETWO-33665 : Refactor Quote module to use mutable data object interfaces 
-- fixes from code review
 -- fixes to testcases
 2015-02-24 17:59:15 -06:00
Alexander Paliarush 722851c54f MAGETWO-33562: Move StoreManagerInterface back from Framework to App 2015-02-03 15:24:33 +02:00
Yuxing Zheng 60ee7cc15e Merge remote-tracking branch 'mainline-ce/develop' into develop 
Conflicts:
	app/code/Magento/Backup/composer.json
	app/code/Magento/Centinel/composer.json
	app/code/Magento/Checkout/Service/V1/Cart/WriteService.php
	app/code/Magento/CheckoutAgreements/Model/CheckoutAgreementsRepository.php
	app/code/Magento/CmsUrlRewrite/composer.json
	app/code/Magento/Core/composer.json
	app/code/Magento/Cron/composer.json
	app/code/Magento/CustomerImportExport/composer.json
	app/code/Magento/Fedex/composer.json
	app/code/Magento/GiftMessage/Service/V1/WriteService.php
	app/code/Magento/GiftMessage/composer.json
	app/code/Magento/GoogleAdwords/composer.json
	app/code/Magento/Integration/composer.json
	app/code/Magento/Log/composer.json
	app/code/Magento/Msrp/composer.json
	app/code/Magento/Multishipping/composer.json
	app/code/Magento/OfflineShipping/composer.json
	app/code/Magento/PageCache/composer.json
	app/code/Magento/Quote/Model/Cart/ShippingMethodConverter.php
	app/code/Magento/Quote/Model/QuoteRepository.php
	app/code/Magento/Quote/composer.json
	app/code/Magento/Rss/composer.json
	app/code/Magento/Sendfriend/composer.json
	app/code/Magento/Shipping/composer.json
	app/code/Magento/Theme/composer.json
	app/code/Magento/Ui/composer.json
	app/code/Magento/User/composer.json
	app/code/Magento/Usps/composer.json
	app/code/Magento/Widget/composer.json
	dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_namespaces.php
	dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Cart/WriteServiceTest.php
	dev/tests/unit/testsuite/Magento/CheckoutAgreements/Service/V1/Agreement/ReadServiceTest.php
	dev/tests/unit/testsuite/Magento/GiftMessage/Service/V1/WriteServiceTest.php
 2015-01-26 12:04:00 -06:00
Alexander Paliarush 5f9cf53767 MAGETWO-32354: Move Magento\Core\Model\Url\RouteParamsResolver.php to Framework 
- Moved Magento\Store\Model\StoreManagerInterface to Magento\Framework\Store\StoreManagerInterface to avoid dependencies on application from the lib
 2015-01-21 16:38:26 +02:00
Serhiy Shkolyarenko 27c4c29077 MAGETWO-32501: Implement Cart Service interfaces 
refactored customer specific methods
fixed totals
 2015-01-19 18:10:47 +02:00
Serhiy Shkolyarenko f8e060ab8d MAGETWO-32009: Catalog category model and tables cleaning 
renamed interfaces back
added test
 2015-01-15 12:50:47 +02:00
Serhiy Shkolyarenko 8e6eceac4a MAGETWO-32501: Implement Cart Service interfaces 
Moved interfaces
 2015-01-15 09:52:13 +02:00
Olexandr Lysenko 428da2e1b6 Merge branch 'develop' into MAGETWO-31593 
Conflicts:
	app/code/Magento/Backend/composer.json
	app/code/Magento/Bundle/composer.json
	app/code/Magento/Catalog/composer.json
	app/code/Magento/CatalogInventory/composer.json
	app/code/Magento/Checkout/composer.json
	app/code/Magento/ConfigurableProduct/composer.json
	app/code/Magento/Customer/composer.json
	app/code/Magento/Dhl/composer.json
	app/code/Magento/Downloadable/composer.json
	app/code/Magento/Fedex/composer.json
	app/code/Magento/GiftMessage/composer.json
	app/code/Magento/GroupedProduct/composer.json
	app/code/Magento/Msrp/composer.json
	app/code/Magento/Multishipping/composer.json
	app/code/Magento/OfflineShipping/composer.json
	app/code/Magento/Payment/composer.json
	app/code/Magento/Persistent/composer.json
	app/code/Magento/Reports/composer.json
	app/code/Magento/Sales/Model/Convert/Quote.php
	app/code/Magento/Sales/Model/Service/Quote.php
	app/code/Magento/Sales/composer.json
	app/code/Magento/SalesRule/composer.json
	app/code/Magento/Shipping/composer.json
	app/code/Magento/Tax/composer.json
	app/code/Magento/Ups/composer.json
	app/code/Magento/Usps/composer.json
	app/code/Magento/Weee/composer.json
	composer.lock
	dev/tests/integration/testsuite/Magento/Sales/Model/Service/QuoteTest.php
	dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_methods.php
	dev/tests/unit/testsuite/Magento/Sales/Model/Convert/QuoteTest.php
	dev/tests/unit/testsuite/Magento/Sales/Model/Resource/QuoteTest.php
 2015-01-12 19:12:45 +02:00
Vladyslav Shcherbyna 44e887cd9a MAGETWO-32102: Move quote models and install 2014-12-24 12:10:40 +02:00