Commit Graph
77 Commits
Author SHA1 Message Date
Jacob Brown 4a633e4039 ACPT-1742
Fixing static test failures.
2024-02-15 09:35:49 -06:00
Jacob Brown 547d3a50e7 ACPT-1742
* Error\ProcessorFactory now uses existing ObjectManager when it exists
  This is required for compatiblity with ApplicationServer
  * Adding metadata to HTTP Response in Error Processor.
  * This new metadata is checked in
    Magento/PageCache/Model/App/Response/HttpPlugin to avoid caching
    errors, and avoid race condition
    * Changed usage of "require_once" to "require" in several places to
      make compatible with ApplicationServer
2024-02-14 13:34:41 -06:00
Pieter Hoste ec423ebeb8 Fixes integration tests 2023-06-06 21:05:40 +02:00
Pieter Hoste f01cf3b4e7 Fixed PHP 8.2 deprecation warnings: 'creation of dynamic property'. 2023-06-06 21:05:40 +02:00
Faizan Shaikh 70571a9245 AC-7790:PHP8.2 - Integration Failures/Unit Failures 2023-01-27 17:41:43 +05:30
venkatashivakumar ebab16f319 AC-1843: Fixed path traversal issue for error reporting 2022-01-13 22:37:44 +05:30
venkatashivakumar 8430a4d30a AC-1843: Fixed path traversal issue for error reporting 2022-01-13 01:06:21 +05:30
Stas Kozar f7b94572d5 MC-34727: Improve error path view file url 2020-06-09 09:02:37 +03:00
Yevhen Miroshnychenko d3498b82ed MC-19421: Reduce q-ty of Reports Created in /app/*/var/report 2019-09-13 16:14:09 -05:00
Yevhen Miroshnychenko b8f70d2e7e MC-19421: Reduce q-ty of Reports Created in /app/*/var/report 2019-09-12 16:12:30 -05:00
Yevhen Miroshnychenko fba65dc8b9 MC-19421: Reduce q-ty of Reports Created in /app/*/var/report 2019-09-12 16:03:09 -05:00
Yevhen Miroshnychenko 8afbd8c977 MC-19421: Reduce q-ty of Reports Created in /app/*/var/report 2019-09-12 13:49:38 -05:00
Mathew Beane cbbdee7447 PHP_EOL in proper spot.
Moved PHP_EOL to file_put_contents so it is not serialized
2019-09-11 12:37:41 -04:00
Mathew Beane fec58c2063 Update processor.php
Added PHP_EOL to the report output.
2019-09-11 10:29:23 -04:00
Yevhen Miroshnychenko 091eb7b900 MC-19421: Reduce q-ty of Reports Created in /app/*/var/report 2019-09-10 14:21:07 -05:00
Lena Orobei 147d11d158 REPO-66: [EQP][Sniffs Consolidation] Deliver Magento Coding Standard to magento2ce
- review fixes
2019-03-29 09:04:55 -05:00
Lena Orobei 7421dfb0a2 REPO-66: [EQP][Sniffs Consolidation] Deliver Magento Coding Standard to magento2ce 2019-03-27 12:14:03 -05:00
Stanislav Idolov aea718bf25 ENGCOM-3250: Replace intval() function by using direct type casting to (int) #18764 2018-10-26 08:59:17 +03:00
Stanislav Idolov a9035918c1 magento-engcom/magento2ce#2262: Code style fixes 2018-10-23 13:19:03 +03:00
vgelani 937f5bcde4 Replace intval() function by using direct type casting to (int) 2018-10-23 13:59:25 +05:30
Stanislav Idolov 52b7d5e876 ENGCOM-3170: Support of error pages behind a load balancer that serves HTTPS #18333 2018-10-23 10:30:58 +03:00
Logan Stellway 7d921b60f8 Removes white space from end of line 384 2018-10-09 07:52:02 -07:00
Logan Stellway 1e28a8e25d Updates docblock comment for _renderPage() method 2018-10-08 09:10:59 -07:00
Ihor Sviziev 320c0aab87 Support of error pages behind a load balancer that serves HTTPS
Use strict comparison
2018-10-07 08:48:28 +03:00
Logan Stellway 422d244443 Fix for #12969 - server port detection for errors
Updates `getHostUrl()` method to reference `HTTP_HOST` rather than `SERVER_PORT`.
2018-10-04 15:36:06 -07:00
stefank 53452fbe0d Support of error pages behind a load balancer that serves HTTPS but accesses the webserver on HTTP. Without this css is loaded on HTTP from a document loaded over HTTPS 2018-10-03 17:15:43 +02:00
stefank b1b39283c1 Support of error pages behind a load balancer that serves HTTPS but accesses the webserver on HTTP. Without this css is loaded on HTTP from a document loaded over HTTPS 2018-10-03 17:04:51 +02:00
stefank e12044867b Support of error pages behind a load balancer that serves HTTPS but accesses the webserver on HTTP. Without this css is loaded on HTTP from a document loaded over HTTPS 2018-10-01 22:33:31 +02:00
Daniel Ruf 435d241cbf chore: use random_int() in some places 2018-05-10 09:54:14 +00:00
Andrew Howden 72c502fd6c Modify Report processor to return 500
The report processor is currently returning a HTTP 503 status
code; generally used for temporarily failures to connect to a service
such as when that service is in maintenance mode, when an upstream
proxy is unavailable etc.

This commit modifies the report HTTP code to be a 500. The author
believes this to be a better reflection that the error is miscellaneous
in nature, and that action is required in order to change it (i.e.
it is not a temporary condition)
2018-03-20 09:17:14 +00:00
Taku acddcce65e fix ports number 2017-08-26 11:32:08 +09:00
Oleksii Korshenko 1b5dc60a26 MAGETWO-66875: Remove the copyright year from file headers #8648 2017-03-29 04:48:40 +03:00
Igor Melnikov c52b20dd5e MAGETWO-65521: Remove unserialize in \Magento\Framework\DB\Adapter\Pdo\Mysql
- fixing class annotation
2017-03-17 01:00:54 -05:00
Igor Melnikov 23b1f7b6d2 MAGETWO-65521: Remove unserialize in \Magento\Framework\DB\Adapter\Pdo\Mysql
- merging with remote tracking branch, conflicts:
pub/errors/processor.php
2017-03-16 22:05:25 -05:00
Tommy Wiebell 5c0461ac2e MAGETWO-65523: Remove serialize/unserialize call in \Magento\Framework\Error\Processor
- Roll back changes to loadReport and re-add to constructor
- Roll back fix to _scriptName setting
- Fix integration test to cover this change
2017-03-15 16:28:08 -05:00
Tommy Wiebell eaacd3a4b8 MAGETWO-65523: Remove serialize/unserialize call in \Magento\Framework\Error\Processor
- Replace generic \Exception
2017-03-15 12:07:48 -05:00
Tommy Wiebell ddd0903a16 MAGETWO-65523: Remove serialize/unserialize call in \Magento\Framework\Error\Processor
- ProcessorTest: Use fully qualified names to resolve static test failure. Add test for expected exception
- processor: Resolve issue with _scriptName being a layer too deep to correctly load assets when loading report
2017-03-15 11:35:28 -05:00
Tommy Wiebell 81db04c866 MAGETWO-65523: Remove serialize/unserialize call in \Magento\Framework\Error\Processor
- Replace usage of setUp in test with creator method. Modified test to use this new method
- Remove redirects and exits from processor, and introduct exception to loadReport method
- Add logic removed from processor to the report
2017-03-14 17:54:18 -05:00
Oleksii Korshenko 60cd97fc47 MAGETWO-65199: [GitHub][PR] [PSR-2 Compliance] Fix #8612: Hundreds of PHPCS-based static tests violations in mainline magento/magento2#8685
- fixed code style issues
2017-03-14 13:53:10 -05:00
Tommy Wiebell 0894e4ee00 MAGETWO-65523: Remove serialize/unserialize call in \Magento\Framework\Error\Processor
- Remove unused DriverInterface dependency and add JSON serializer
- Fix docblock spacing
- Removed exit and die statements that were unnecessary after header re-directs, which allowed for testing
- Changed re-direct header location to go back to home page instead of un-styled ./pub destination
- Add integration test to cover changes to two methods touched
2017-03-14 11:36:12 -05:00
Vlad Veselov 002d771100 [PSR-2 Compliance] Fix #8612: Hundreds of PHPCS-based static tests violations in mainline
- apply automatic PHPCBF fixes to make PHPCS happy
- Step 0. Install phpcs globally: composer global require squizlabs/php_codesniffer:2.8.0
- Step 1. Execute tool to fix PSR-2 violations in PHP files: ~/.composer/vendor/squizlabs/php_codesniffer/scripts/phpcbf --standard=PSR2 --extensions=php --ignore=generated/*,vendor/*,var/* .
2017-03-11 13:45:04 +02:00
Vlad Veselov 8d379e666c [PSR-2 Compliance] Fix #8612: Hundreds of PHPCS-based static tests violations in mainline
- apply manual fixes to make PHPCS and PHPMD happy
- some phtml templates marked as ignored for now as PHPCS 1.5.3 version produces false-positives on them (PHPCS 2.8.0 treats them fine)
2017-03-11 13:19:58 +02:00
James Halsall a31f4a35c0 Remove the copyright year from file headers 2017-02-22 09:09:36 +00:00
Sergii Kovalenko eb30343a09 MAGETWO-62855: Copyright Year Update 2017 2017-01-05 13:01:45 +02:00
Arkadii Chyzhov 87891a7f71 MAGETWO-52323: [Github] Error page/maintenance page skin customisation is not currently possible #4305 2016-06-06 19:29:34 +03:00
Arkadii Chyzhov 1cd6f19f80 MAGETWO-52323: [Github] Error page/maintenance page skin customisation is not currently possible #4305 2016-06-06 17:13:40 +03:00
Dale Sikkema 642127547a MAGETWO-50284: stop controlling FS permissions on application level 2016-03-19 19:58:10 -05:00
Joan He 84dd7f0c3b MAGETWO-48081: Copyright Year Update 2016-03-18 14:34:38 -05:00
Willem de Groot dc9b9a16bc Get realpath for DOCUMENT_ROOT to support symlinking 2016-02-03 13:27:11 +01:00
Joan He 3b819cf5a5 MAGETWO-36791: Fixed too broad permissions on files
-address CR comments
2015-08-26 22:40:54 -05:00