Stanislav Malyshev
ef648e3182
Merge branch 'PHP-7.2' into PHP-7.3
...
* PHP-7.2:
Fix #79877 : getimagesize function silently truncates after a null byte
Fix #79797 : Use of freed hash key in the phar_parse_zipfile function
2020-08-04 09:20:13 +01:00
Christoph M. Becker
4b96a75ffd
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix #63527 : DCOM does not work with Username, Password parameter
2020-07-20 14:44:18 +02:00
Christoph M. Becker
b2e3fd1e69
Fix #63527 : DCOM does not work with Username, Password parameter
...
We must not mix multibyte and wide character strings in the
`COAUTHIDENTITY` structure. Using wide character strings throughout
would have the advantage that the remote connection can be established
regardless of the code page of the server, but that would more likely
break BC, so we just drop the wide character string conversion of the
username.
2020-07-20 14:43:29 +02:00
Nikita Popov
0c28b47154
Fixed bug #79839
...
Add reference type sources in array_walk.
2020-07-17 14:50:22 +02:00
Christoph M. Becker
c1b5e7a9ab
Enable further tests on Windows
2020-07-16 16:07:23 +02:00
Christoph M. Becker
dd1d1191e1
Fix tests regarding negative fileinode()
...
The results of `fileinode()` may be negative due to wrap-around
behavior (at least on Windows as of PHP 7.4.0).
2020-07-15 16:38:38 +02:00
Nikita Popov
2053329b1a
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix bug #78008 : dns_check_record() always return true on Alpine
2020-07-15 15:10:40 +02:00
Andy Postnikov
2c57378bd3
Fix bug #78008 : dns_check_record() always return true on Alpine
...
- free handle before return result
- cleaned up remaining usage of MAXPACKET
- update dns_get_mx() to use the same approach
Closes GH-5854.
2020-07-15 15:10:19 +02:00
Christopher Broadbent
ee7c7a8e26
Fixed bug #79820
...
Similar to what is done for ReflectionType itself, copy the
type name stored inside ReflectionProperty. Also make sure the
type field is always initialized for dynamic properties.
This is a non-issue in PHP 8, because we store a pointer to the
property_info there, rather than a copy.
2020-07-15 10:58:56 +02:00
Nikita Popov
f855b59994
Merge remote-tracking branch 'upstream/PHP-7.4' into PHP-7.4
...
* upstream/PHP-7.4:
Fix test for x86 Windows
2020-07-14 12:43:58 +02:00
Nikita Popov
162776a132
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fixed bug #79849
2020-07-14 12:42:46 +02:00
Evgeny Stepanischev
ce149b0cb8
Fixed bug #79849
...
Closes GH-5853.
2020-07-14 12:41:43 +02:00
Christoph M. Becker
e2c17cef4b
Fix test for x86 Windows
...
`st_dev` deliberately overflows on such systems, cf.
<http://svn.php.net/viewvc?view=revision&revision=350100 >.
2020-07-13 10:52:26 +02:00
twosee
7a39e174aa
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fixed BC break of php_debug_zval_dump
2020-07-11 18:31:30 +08:00
twosee
f0b2c2cb98
Fixed BC break of php_debug_zval_dump
...
It introduced by fixing bug #79830
2020-07-11 18:30:28 +08:00
twosee
6ef08b1903
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fixed bug #79830 introduced by fixing bug #79821
2020-07-11 14:38:27 +08:00
twosee
56dec3cc73
Fixed bug #79830 introduced by fixing bug #79821
...
This also fixes memory error in debug_zval_dump and var_export.
2020-07-11 14:37:25 +08:00
twosee
8db2ae8ffb
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fixed bug #79821
2020-07-11 06:15:28 +08:00
twosee
150504e6b1
Fixed bug #79821
...
HashTable was reallocated (zend_hash_packed_grow) during php_var_dump, so we should call GC_ADDREF to make SEPARATE_ARRAY work.
Closes GH-5837.
2020-07-11 06:14:22 +08:00
Nikita Popov
3f8d71d37f
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fixed bug #79817
2020-07-10 14:07:17 +02:00
Nikita Popov
a72c53a070
Fixed bug #79817
...
Use *_IND macros in a few places in string.c.
2020-07-10 14:06:41 +02:00
Christoph M. Becker
99aa5484e2
Enable further ext/standard/tests/file tests on Windows
2020-07-10 13:36:41 +02:00
Christoph M. Becker
7edc5e5e39
Fix skip reasons
...
These tests fail on Windows for different reasons, but not because
symlinks, links, or lstat() would not be supported on Windows
generally.
2020-07-10 11:26:48 +02:00
Christoph M. Becker
68293b19d4
Enable symlink_link_linkinfo_is_link_* tests on Windows
...
We mark symlink_link_linkinfo_is_link_error2.phpt as XFAIL on Windows
ZTS. Several Windows API file system functions ignore trailing spaces
in absolute filenames after the final directory separator, which causes
`link(' ', $link)` to actually call `CreateHardLink()` which then
fails, because linking folders is not supported. However, with NTS
builds (as well as on other systems), the $target is found to not
exist, so the function fails without actually attempting to create the
link. This needs further investigation.
2020-07-10 10:08:12 +02:00
Paweł Tomulik
b291c92693
enable ext/ldap/tests on azure
2020-07-10 09:56:02 +02:00
Paweł Tomulik
c6ab3084df
fix some ext/ldap/tests
2020-07-10 09:56:02 +02:00
Nikita Popov
22352868ec
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix some memory bugs in ldap.c
2020-07-10 09:49:50 +02:00
Paweł Tomulik
23ef0a1285
Fix some memory bugs in ldap.c
2020-07-09 18:35:00 +02:00
Christoph M. Becker
db484b612d
Prevent parallel test conflicts
...
Both tests used the same folder, which could clash in case the tests
are run simultaneously.
2020-07-09 12:35:31 +02:00
Nikita Popov
77a8a709da
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix bug #79787
2020-07-08 11:22:18 +02:00
XXiang
3d5de7d746
Fix bug #79787
...
Closes GH-5807.
2020-07-08 11:20:58 +02:00
Nikita Popov
e6160e99d8
Report len as -1 instead of INT_MAX
...
Per docs it should be -1. And would be on 32-bit systems, but
not on 64-bit systems.
(cherry picked from commit 39111585a2 )
2020-07-08 10:38:11 +02:00
Christoph M. Becker
a58d865f65
Fix tests for x86 Windows
...
`st_dev` deliberately overflows on such systems, cf.
<http://svn.php.net/viewvc?view=revision&revision=350100 >.
2020-07-03 10:37:40 +02:00
Christoph M. Becker
1b961c0c42
Skip test if SeCreateSymbolicLinkPrivilege is not given
2020-07-03 09:08:59 +02:00
Christoph M. Becker
6f0b73345a
Enable readlink_realpath_* tests on Windows
...
We modify _basic1.phpt so it runs on Windows as well. The other test
cases hit the issue that `readlink()` fails normally for regular files,
but succeeds on Windows[1]. Therefore, we split these tests, but still
fix the skip reasons.
[1] <http://svn.php.net/viewvc?view=revision&revision=350097 >
2020-07-02 18:24:42 +02:00
Christoph M. Becker
1973ca21bd
Enable most lstat_stat_* tests on Windows
...
Most of these have been skipped on Windows for no good reason (`lstat`
is available there as of PHP 4). Several others would only fail,
because the `blksize` and `blocks` elements are always `-1` on Windows,
which can easily be fixed by using `%i` format specifiers instead of
`%d`.
2020-07-02 15:36:07 +02:00
Christoph M. Becker
c49fb83c38
Extract test helper function for SeCreateSymbolicLinkPrivilege check
2020-07-02 12:23:49 +02:00
Nikita Popov
f1bf058d7c
Handle SO_ options only at SOL_SOCKET level
...
These options may have the same value as options at other levels.
This issue showed up on ppc64el.
2020-07-02 11:41:08 +02:00
Nikita Popov
0a216f5edb
Allow different error message for errno 58
...
Apparently this is EDEADLOCK on some systems.
2020-07-02 11:39:22 +02:00
Christoph M. Becker
993b19ae69
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix #70362 : Can't copy() large 'data://' with open_basedir
2020-06-30 10:48:07 +02:00
Christoph M. Becker
7f3bc64287
Fix #70362 : Can't copy() large 'data://' with open_basedir
...
open_basedir is only relevant for plain files, so there is no need to
check it for other URL wrappers.
2020-06-30 10:46:53 +02:00
Christoph M. Becker
4af69b8477
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix #63208 : BSTR to PHP string conversion not binary safe
2020-06-29 19:06:00 +02:00
Christoph M. Becker
a385cfa7ad
Fix #63208 : BSTR to PHP string conversion not binary safe
...
A `BSTR` is similar to a `zend_string`; it stores the length of the
string just before the actual string, and thus the string may contain
NUL bytes. However, `php_com_olestring_to_string()` is supposed to
deal with arbitrary `OLECHAR*`s which may not be `BSTR`s, so we
introduce `php_com_bstr_to_string()` and use it for the only case where
we actually have to deal with `BSTR`s which may contain NUL bytes.
Contrary to `php_com_olestring_to_string()` we return a `zend_string`,
so we can save the re-allocation when converting to a `zval`.
We also cater to `php_com_string_to_olestring()` not being binary safe,
with basically the same fix we did for `php_com_olestring_to_string()`.
2020-06-29 19:05:02 +02:00
Christoph M. Becker
dfac28f8d8
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix #79756 : finfo_file crash (FILEINFO_MIME)
2020-06-29 17:46:46 +02:00
Christoph M. Becker
816b4c1235
Fix #79756 : finfo_file crash (FILEINFO_MIME)
...
If `ctime` or `asctime` return `NULL`, we must not attempt to copy the
buffer, but rather return `NULL` as well.
2020-06-29 17:45:28 +02:00
Nikita Popov
fabcd9f14e
Don't inline static call to instance method
...
Fixes the failure in bug79740.phpt with opcache.
2020-06-29 09:52:37 +02:00
Nikita Popov
978cdb736a
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fixed bug #79741
2020-06-26 12:29:23 +02:00
Nikita Popov
43cd3f6814
Fixed bug #79741
2020-06-26 12:28:39 +02:00
Nikita Popov
565baf05c0
Handle *0 / *1 more consistently
...
Avoid throwing a DES salt deprecation warning if the libc crypt
implementation is used.
2020-06-24 12:22:07 +02:00
Christoph M. Becker
32257ac17f
Fix potential environment variable deadlock
...
We have to unlock the environment before bailing out.
2020-06-24 11:44:07 +02:00